fix: update website after changing tag value #250
Conversation
|
Needs testing. I'll update this message after testing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
- Coverage 95.06% 94.55% -0.52%
==========================================
Files 5 5
Lines 324 367 +43
==========================================
+ Hits 308 347 +39
- Misses 16 20 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@areebahmeddd it won't fix #122, because there is a part in openfoodfacts-server javascript, so please remove the "Fix:" in your description (which would close the issue). Or if you close the issue, please open a new issue on openfoodfacts-server to ask to leverage this new API feature in the javascript to display the property. |
| # Return the updated tag instead of just "ok" | ||
| return product_tag |
There was a problem hiding this comment.
This is a change in the API we must ensure no depending app will crash because of this…
One way to avoid this is to add a parameter to ask for the product_tag as return value, and return "ok" otherwise.
It might be that mobile app only use the response http status code, in which case it is ok, but please ask them first (opening an issue in their github repository).
Signed-off-by: Areeb Ahmed [email protected]
Summary of Changes
Fixes: #122
product_tag_updatefunction to return the updated tag value after an update.